Skip to content

[3.12] gh-127805: Clarify Formatter initialization in logging.rst. (GH-127850)#130393

Merged
terryjreedy merged 1 commit into
python:3.12from
miss-islington:backport-5d66c55-3.12
Feb 24, 2025
Merged

[3.12] gh-127805: Clarify Formatter initialization in logging.rst. (GH-127850)#130393
terryjreedy merged 1 commit into
python:3.12from
miss-islington:backport-5d66c55-3.12

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

…thonGH-127850)

(cherry picked from commit 5d66c55)

Co-authored-by: UV <yuvrajpradhan667@gmail.com>
@ghost

ghost commented Feb 21, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@vsajip

vsajip commented Feb 21, 2025

Copy link
Copy Markdown
Member

@Uvi-12 Did you change your email address or something? Apparently we've lost track of your CLA signature, so can you please re-sign? This and the backport PR for 3.13 are affected. Thanks!

@terryjreedy terryjreedy added the pending The issue will be closed if no feedback is provided label Feb 24, 2025
@terryjreedy

Copy link
Copy Markdown
Member

The addition is "The fmt argument must be a :class:Formatter instance or None." This nice addition is too substantial to 'steal' (merge under a new name) but IMO not substantial enough to go to lots of extra work to merge if @Uvi-12 never responds. DItto for 3.13 backport.

@Uvi-12

Uvi-12 commented Feb 24, 2025

Copy link
Copy Markdown

Sorry for the late. I have signed the CLA, is there anything I will have to do after that?

@terryjreedy terryjreedy merged commit da471d9 into python:3.12 Feb 24, 2025
@AA-Turner AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025
@miss-islington miss-islington deleted the backport-5d66c55-3.12 branch January 2, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants